From 25c6301cf0350555a72d2a6a0c9e03079d1ef9cd Mon Sep 17 00:00:00 2001 From: sapradhan Date: Sat, 30 Dec 2023 15:14:25 +0545 Subject: [PATCH 1/2] toggle active on correct element active should be toggled on span.nav-item. clicking on svg was toggling active its parent - span.nav-link instead. --- assets/js/main.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assets/js/main.js b/assets/js/main.js index 73fa884..3b3e302 100755 --- a/assets/js/main.js +++ b/assets/js/main.js @@ -10,7 +10,7 @@ dropdownMenuToggler.forEach((toggler) => { toggler?.addEventListener("click", (e) => { - e.target.parentElement.classList.toggle("active"); + e.target.closest('.nav-item').classList.toggle("active"); }); }); From 41a2b89c23a1ccc7b41d37132d01c3d703c69a19 Mon Sep 17 00:00:00 2001 From: sapradhan Date: Sat, 30 Dec 2023 15:50:02 +0545 Subject: [PATCH 2/2] consistent mouse pointer over menu with and without children --- assets/scss/navigation.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assets/scss/navigation.scss b/assets/scss/navigation.scss index 7538a33..24fc9e1 100755 --- a/assets/scss/navigation.scss +++ b/assets/scss/navigation.scss @@ -36,7 +36,7 @@ input#nav-toggle:checked ~ #nav-menu { // } .nav-link { - @apply text-dark hover:text-primary dark:text-darkmode-dark dark:hover:text-darkmode-primary block p-3 font-semibold transition lg:px-2 lg:py-3; + @apply text-dark hover:text-primary dark:text-darkmode-dark dark:hover:text-darkmode-primary block p-3 cursor-pointer font-semibold transition lg:px-2 lg:py-3; } .nav-dropdown {